Add permissions for ELB to create service linked roles #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Actual AWS IAM policy conditions can be of various types. Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
iam-aws-new-account-support
branch
from
1c8b3f6
to
9c31fa9
Compare
k8s-ci-robot
added
size/M
randomvariable
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
randomvariable
force-pushed
the
iam-aws-new-account-support
branch
from
9c31fa9
to
ae0a487
Compare
|
Ready for review |
vincepri
reviewed
Jan 23, 2019
pkg/cloud/aws/services/iam/types.go
Outdated
| } | ||
|
|
||
| // NewManagedName creates an IAM acceptable name prefixed with this Cluster API | ||
| // implementation's prefix. | ||
| func NewManagedName(prefix string) string { | ||
| return fmt.Sprintf("%s.%s", prefix, IAMSuffix) | ||
| } | ||
|
|
||
| // ProcessPolicyDocument replaces IAMConditions with Condition to work around | ||
| // GoFormation |
There was a problem hiding this comment.
Can we add a little bit more context on why this is needed?
There was a problem hiding this comment.
Extended the comment on both that function and the StatementEntry type.
GoFormation processes "Condition" keys as CFN intrinsics. Renames Condition to IAMConditions until GoFormation supports IAM properly. Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
Allow AWS ELB to create its own Service Linked AWS IAM role to be able to manage instances linked to an ELB. Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
iam-aws-new-account-support
branch
from
ae0a487
to
61b17df
Compare
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #422
Permits ELB, as an Amazon-managed service, to create a role to access EC2 in the customer's account, which is needed to attach the control plane instances to a load balancer.
Special notes for your reviewer:
In order to test this, ELB will create a
AWSServiceRoleForElasticLoadBalancingusing these IAM permissions. If all ELBs are deleted, then this role can be deleted and then the account is reusable for testing this feature.Release note: